Skip to content

[doc] html enhancements #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

felixmulder
Copy link
Contributor

@felixmulder felixmulder commented Feb 3, 2017

There were a couple of things missing / forgotten, this is what's fixed in this PR:

  • ability to expand docstrings using a [+] symbol
  • type paramters added to entity title (top of page)
  • return type references rendered correctly for (most) types
  • type aliases now get their docstrings and references to their rhs if applicable
  • adds constructors to the docs

To verify or generate the site, simply clone this branch and issue sbt genDocs, this will put a site in docs/_site/index.html.

Caveats

Constructors are unfortunately not modelled as defs therefore, their docstrings are lost. This should be fixed in a future PR.

Some references that were previously broken, are unfortunately - still broken. This PR does not aim to address this.

Comments to reviewer(s)

I would like to get this in before Monday, so it'd be grrrreat if one of you guys could review this quickly - I don't need reviews from all of you (unless you REALLY REALLY want to ❤️)

@felixmulder felixmulder force-pushed the topic/dottydoc-html-enhancements branch from 63bdd7b to 5995dd3 Compare February 3, 2017 16:21
Copy link
Contributor

@OlivierBlanvillain OlivierBlanvillain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (.asJava)

@felixmulder
Copy link
Contributor Author

@OlivierBlanvillain: agreed :)

@felixmulder felixmulder merged commit da7d723 into scala:master Feb 3, 2017
@allanrenucci allanrenucci deleted the topic/dottydoc-html-enhancements branch December 14, 2017 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants